Add stylelint as an alternate CSS linter. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note this assumes a few things:
1. Your stylelint configuration can be auto-detected. That is to say, as
of stylelint version 8.4.0:
* your configuration is located in a stylelint property in
`package.json`, or,
* your configuration is located in a `.stylelintrc` file (with or
without one of the following filename extensions: .json, .yaml,
.yml, and .js) in the current directory or one of its ancestors,
or,
* your configuration is located in a `stylelint.config.js` file
exporting a JS object, located in the current directory or one of
its ancestors.
I found that, if my config was named `.stylelintrc`, it could not
contain a 'use strict' statement at the beginning of the file nor the
assignment 'module.exports = ' before the JSON array of settings.
This may have been unique to my environment.
2. Your stylelint configuration doesn't contain any global dependencies.
That is to say, stylelint has been installed with `npm install -g
stylelint`, but packages such as stylelint-config-standard and
stylelint-no-browser-hacks has been installed locally with `npm
install stylelint-config-standard stylelint-no-browser-hacks`.
If you do have global dependencies, you will need to add a
`--config-basedir` argument to the `stylelint "$file"` line in
`pre-commit/2-css-style-stylelint.sh`, e.g.:
stylelint --config-basedir /usr/local/lib/node_modules/ "$file"
- .theme is new in D8 - Drupal sniffs can run on js, css, and yml files
- .theme is new in D8 - DrupalPractice sniffs can run on yml files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by Clean CSS with Stylelint by @dbuytaert.
Note the linter added in this pull request assumes some changes from the configuration presented in the post above:
In order for stylelint to pick up its configuration automatically, I had to:
stylelint.jsto.stylelintrc,'use strict'statement at the beginning of the file, and,module.exports =assignment before the JSON settings array.In order for stylelint to work with the configuration file, but not require the --config-basedir argument, I had to:
Install stylelint-config-standard and stylelint-no-browser-hacks locally, i.e.:
See the d6bf406 commit message for a bit more information.